Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SyntaxError #48

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: SyntaxError #48

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
572c205
fix: SyntaxError
rachmadaniHaryono Feb 18, 2022
7ed1044
ci: test compileall
rachmadaniHaryono Feb 18, 2022
8669e51
refactor(keymaps): remove unnecessary list addition
rachmadaniHaryono Jul 23, 2022
1582e6d
style(keymaps): fix comment
rachmadaniHaryono Jul 26, 2022
0262f36
style(keymaps): more clear comment on home and end
rachmadaniHaryono Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pyrepl/keymaps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@
(r"\<home>", "home"),
(r"\<f1>", "help"),
(r"\EOF", "end"), # the entries in the terminfo database for xterms
(r"\EOH", "home"), # seem to be wrong. this is a less than ideal
# workaround
(r"\EOH", "home"), # seem to be wrong. this is a less than ideal workaround
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it appears with "home" only, but likely is also meant for "end". (just from what I think/see, no idea really).
I wanted to ensure that the comment's meaning/location/reference is kept (which was given before due to whitespace alignment), but now it is even less clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I agree. It looks like the comment spans multiple lines and starts with "the entries in the terminfo database.." IMO it should be on a separate line, before the end & home lines.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0262f36 fix that

should there be new line between help and comment? if yes, i will create another commit for that

]
)

Expand Down