Add UCS-2 builds of Python to the docker image #35
Conversation
/opt/<major><soabi_flags> and /opt/<full><soabi_flags> are the more specific paths.
| fi | ||
| for soabi_flags in $soabi_flags_list; do | ||
| /opt/${PYVER}${soabi_flags}/bin/python $MY_DIR/manylinux1-check.py | ||
| done |
There was a problem hiding this comment.
This should probably just be
for PYTHON in /opt/*/bin/python; do
$PYTHON $MY_DIR/manylinux1-check.py
done
it's a bit redundant (checks the same interpreters repeatedly), but the test takes a fraction of a second so who cares -- being thorough and robust seems more important.
|
Also, what's the |
|
Otherwise LGTM. One possible further enhancement would be to implement @rmcgibbo's suggestion here: #29 (comment) |
|
|
|
How about |
Oh, of course, sorry.
I don't think it matters that much, so whatever you prefer really :-). Just so long as one can write |
|
Otherwise this looks good to merge to me -- do you want to keep extending this, or just merge as-is and do that as a separate PR? |
|
I'll update shortly. |
not include SOABI flags. `for py in /opt/*/bin/python` will now allow looping over all supported builds.
|
Okay, with the latest change: nate@mjolnir0% docker run --rm --entrypoint=/bin/sh natefoo/manylinux1_x86_64 -c 'ls -l /opt /opt/python; for py in /opt/python/*/bin/python; do $py -V; done'
/opt:
total 28
lrwxrwxrwx 1 root root 19 Mar 8 14:47 2.6m -> /opt/python/2.6.9m/
lrwxrwxrwx 1 root root 20 Mar 8 14:46 2.6mu -> /opt/python/2.6.9mu/
lrwxrwxrwx 1 root root 20 Mar 8 14:51 2.7m -> /opt/python/2.7.11m/
lrwxrwxrwx 1 root root 21 Mar 8 14:49 2.7mu -> /opt/python/2.7.11mu/
lrwxrwxrwx 1 root root 19 Mar 8 14:53 3.3m -> /opt/python/3.3.6m/
lrwxrwxrwx 1 root root 19 Mar 8 14:55 3.4m -> /opt/python/3.4.4m/
lrwxrwxrwx 1 root root 19 Mar 8 14:56 3.5m -> /opt/python/3.5.1m/
drwxr-xr-x 1 root root 92 Mar 8 14:55 python
drwxr-xr-x 1 root root 24 Mar 8 14:41 rh
/opt/python:
total 0
drwxr-xr-x 1 root root 36 Mar 8 14:47 2.6.9m
drwxr-xr-x 1 root root 36 Mar 8 14:46 2.6.9mu
drwxr-xr-x 1 root root 36 Mar 8 14:51 2.7.11m
drwxr-xr-x 1 root root 36 Mar 8 14:49 2.7.11mu
drwxr-xr-x 1 root root 36 Mar 8 14:53 3.3.6m
drwxr-xr-x 1 root root 36 Mar 8 14:55 3.4.4m
drwxr-xr-x 1 root root 36 Mar 8 14:56 3.5.1m
Python 2.6.9
Python 2.6.9
Python 2.7.11
Python 2.7.11
Python 3.3.6
Python 3.4.4
Python 3.5.1 |
|
@njsmith Does this need anything else? |
|
Mailing list discussion: https://mail.python.org/pipermail/wheel-builders/2016-March/000051.html |
|
This looks good to me but the README.md should be updated to document the new structure of the folders and the meaning of the "m" as you did in the email you sent to the wheel-builders mailing list. |
|
@ogrisel Ok, I updated the README. |
|
LTGM, +1 for merge. |
Add UCS-2 builds of Python to the docker image
/opt/<major>links to the UCS-4 builds, but/opt/<major><soabi_flags>and/opt/<full><soabi_flags>are the more specific paths: