Fix filtering of verify and should fix #1488 #1690
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I run in the same problem as the user of issue #1488 and this PR should fix the bug. Because none of the json files have a version field, I was first looking where this field come from. A review with git blame of
verify.py
don't helped a lot and I'm not sure, how this code should ever work.To fix that, I wrapped the json package inside a Package class object and call the same functions as the mirror class do and it seems to work as expected.
Please check my PR. If I had made any mistakes or I don't understand how it should work, I will promise to fix that ASOP.