Reset the offset in finding control block #1654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the control block id was not found in cases where the bytes spanned two read blocks. Example data block causing the original issue: `01:08:18.444,458] <dbg> SEGGER R` In this case the code skips 24 bytes, making the next loop start with: `SEGGER RTT\x00\x00\x00\x00…` Unfortunately `offset` is still `8`, which the first byte does not match. The offset is then reset, but by that time the first byte has already been skipped over.
|
Superseded by #1669 (proposal) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the control block id was not found in cases where the bytes spanned two read blocks.
Example data block causing the original issue:
01:08:18.444,458] <dbg> SEGGER RIn this case the code skips 24 bytes, making the next loop start with:
SEGGER RTT\x00\x00\x00\x00…Unfortunately
offsetis still8, which the first byte does not match. The offset is then reset, but by that time the first byte has already been skipped over.Re: #1553