Add rtt control block into YAML config #1418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the way in the `jlink_probe` module of getting configs
|
This pull request introduces 2 alerts when merging 4518c1d into a29d167 - view on LGTM.com new alerts:
|
flit
requested changes
Jun 13, 2022
Note: `elftools` version requirement may be too strict
flit
requested changes
Jun 25, 2022
| @@ -63,6 +63,7 @@ install_requires = | |||
| pyyaml>=6.0,<7.0 | |||
| six>=1.15.0,<2.0 | |||
| typing-extensions>=4.0,<5.0 | |||
| elftools>=0.28 | |||
There was a problem hiding this comment.
This package doesn't exist. The package on PyPI is actually called pyelftools, and is already a pyocd dependency. 😄
Comment on lines
+138
to
+143
| elf = ELFFile(open(self._args.elf, "rb")) | ||
| symtab = elf.get_section_by_name(".symtab") | ||
| if symtab: | ||
| rtt_entry = symtab.get_symbol_by_name("_SEGGER_RTT") | ||
| if len(rtt_entry) > 0: | ||
| rtt_cb_addr = rtt_entry[0].entry["st_value"] |
There was a problem hiding this comment.
Fyi, pyocd has some built-in support for ELF symbol extraction (and other things) in the pyocd.debug.elf sub-package. It's based on pyelftools, so for cases like this, where there is not much advantage, it's fine to directly use pyelftools. So no need to rewrite this.
For reference, this is what this code would look like using pyocd's ELF tools:
sym_info = ELFBinaryFile(self._args.elf).symbol_decoder.get_symbol_by_name('_SEGGER_RTT')
if sym_info:
rtt_cb_addr = sym_info.value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the way in the
jlink_probemodule of getting configs.Fixes the first 2 requirements in #1417