-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restore the last napari-micromanager layout at startup #317
Open
fdrgsp
wants to merge
24
commits into
pymmcore-plus:main
Choose a base branch
from
fdrgsp:restore_layout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+135
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 78.24% 79.23% +0.99%
==========================================
Files 13 13
Lines 625 684 +59
==========================================
+ Hits 489 542 +53
- Misses 136 142 +6 ☔ View full report in Codecov by Sentry. |
…romanager into restore_layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this PR, when we save the state of the
QMainWindow
in ajson
file so that when we re-opennapari-micromanager
again the saved layout is restored.the
json
file has two keys:layout_state
: where the state of thenapari QMainWindow
is stored using thesaveState()
method (the state isbase64
encoded to be able to save it to thejson
file)pymmcore_widgets
where the names of the dockedpymmcore_widgets
are stored. The "pymmcore_widgets" key is crucial in our layout saving process. It stores the names of all active pymmcore_widgets at the time of saving. Before restoring the layout, we must recreate these widgets. If not, they won't be included in the restored layout (this is because thepymmcore-widgets
are not created at the startup but only when the user clicks on theirQPushButton
).The
json
file is saved in theappdirs.user_data_dir
path in a folder namednapari_micromanager
.This PR also adds a
ScrollableWidget
to house thepymmcore_widgets
. This allows for easy docking of widgets either above or below others, ensuring they remain within the monitor's display area and do not overflow off-screen.