Fix: [unknown-option-value] False negative after --disable=all #9491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Keck <[email protected]>
Signed-off-by: Dennis Keck <[email protected]>
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
changed the title
Pierre-Sassoulas
added
Work in progress
False Negative π¦
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
the
Needs take over ποΈ
I plan to take another look but lately had not really much capacity. If the issue is urgent though, please feel free to take over. |
Pierre-Sassoulas
removed
the
Needs take over ποΈ
Signed-off-by: Dennis Keck <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Dennis Keck <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Dennis Keck <[email protected]>
fellhorn
force-pushed
the
dennis/fix/all-messages
branch
from
52a8742
to
7809902
Compare
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9491 +/- ##
==========================================
- Coverage 95.82% 95.79% -0.03%
==========================================
Files 174 174
Lines 18813 18925 +112
==========================================
+ Hits 18027 18130 +103
- Misses 786 795 +9
|
DanielNoord
reviewed
Jun 17, 2024
pylint/constants.py
Outdated
| @@ -43,6 +43,19 @@ | |||
| MSG_TYPES_LONG: dict[str, str] = {v: k for k, v in MSG_TYPES.items()} | |||
|
|
|||
| MSG_TYPES_STATUS = {"I": 0, "C": 16, "R": 8, "W": 4, "E": 2, "F": 1} | |||
| PYLINT_MSGS = [ | |||
There was a problem hiding this comment.
Can we get this dynamically from the PyLinter class?
There was a problem hiding this comment.
Thanks @DanielNoord, I now understood the meaning of the MSGS constant after taking another look and got rid of this unnecessary additional constant.
Do you mind taking another look?
jacobtylerwalls
removed
the
Waiting on author
jacobtylerwalls
added
the
Waiting on author
fellhorn
force-pushed
the
dennis/fix/all-messages
branch
2 times, most recently
from
01911de
to
8449c81
Compare
Signed-off-by: Dennis Keck <[email protected]>
fellhorn
force-pushed
the
dennis/fix/all-messages
branch
from
8449c81
to
453c9e1
Compare
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
removed
the
Waiting on author
jacobtylerwalls
requested changes
Jul 21, 2024
|
You can |
Signed-off-by: Dennis Keck <[email protected]>
Signed-off-by: Dennis Keck <[email protected]>
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 6548d2c |
jacobtylerwalls
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9403 by excluding a set of internal pylint messages from
--disable=all.As this is my first PR to pylint I appreciate any comment on the solution. Especially in regards of the message codes and having to change an existing test.