Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the overwriting of sys.argv #961

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

nbelakovski-mssm
Copy link
Contributor

There's no need to do this since argparse can accept a list of arguments, and it doesn't seem like a good idea to overwrite the list of arguments provided.

Reference issue

N/A

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy
  • Apps updated and tested (if relevant)

There's no need to do this since argparse can accept a list of
arguments, and it doesn't seem like a good idea to overwrite the list of
arguments provided.
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ca0fda1) to head (ec1aa5d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #961   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         8708      8708           
=========================================
  Hits          8708      8708           
Files Coverage Δ
pynetdicom/__main__.py 100.00% <100.00%> (ø)

@scaramallion scaramallion merged commit b7f54bb into pydicom:main Jul 29, 2024
11 checks passed
@scaramallion
Copy link
Member

Thanks!

@nbelakovski-mssm nbelakovski-mssm deleted the remove_sys_argv branch July 30, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants