Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate coordinates with indexes on sub-trees #9531

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Remove duplicate coordinates with indexes on sub-trees #9531

merged 3 commits into from
Sep 26, 2024

Commits on Sep 22, 2024

  1. Remove duplicate coordinates with indexes on sub-trees 

    This is a _partial_ solution to the duplicate coordinates issue from pydata#9475.

Here we remove all duplicate coordinates between parent and child nodes
with an index (these are already checked for equality via the alignment
check).

Other repeated coordinates (which we cannot automatically check for
equality) are still allowed for now. We will need an alternative
solution for these, as discussed in pydata#9475, but it is less obvious
what the right solution is so I'm holding off on it for now.
    @shoyer
    shoyer committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    0541f28 View commit details
    Browse the repository at this point in the history

  2. silence mypy error

    @shoyer
    shoyer committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    b3d3eaa View commit details
    Browse the repository at this point in the history

  3. edits per review

    @shoyer
    shoyer committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    9cde264 View commit details
    Browse the repository at this point in the history