Fix pandas datetime decoding with NumPy >= 2.0 for small integer dtypes #9518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @langmore for noting this issue and suggesting this workaround.
spencerkclark
commented
Sep 19, 2024
Comment on lines
+1454
to
+1455
| "mixed-cftime-pandas-encoding-with-prescribed-units-and-dtype": pytest.param( | ||
| "250YS", "days since 1700-01-01", np.dtype("int32"), marks=requires_cftime |
There was a problem hiding this comment.
Not related to this PR, but I noticed when testing in an environment without cftime that this test was not skipped. I guess we don't have a CI environment that has dask, but not cftime. I figured I would take the opportunity to clean this up.
3 tasks
shoyer
approved these changes
Sep 19, 2024
hollymandel
pushed a commit
to hollymandel/xarray
that referenced
this pull request
Sep 23, 2024
…es (pydata#9518) * Fix pandas datetime decoding with np.int32 values and NumPy >= 2 Thanks @langmore for noting this issue and suggesting this workaround. * Refine what's new entry
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue that @langmore brought up in #9498 (review). Thanks again for noting this and suggesting the fix.
I modified an existing test such that it will no longer fall back to cftime, so that it fails without this fix even if cftime is installed.
whats-new.rst