Make _replace more lenient. #9517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dcherian
commented
Sep 18, 2024
dcherian
commented
- Closes Inconsistent behavior in grouby depending on the dimension order #5361
- Tests added
dcherian
commented
Sep 18, 2024
xarray/core/dataarray.py
Outdated
Comment on lines
537
to
538
| dims_are_equal = set(variable.dims) == set(self.dims) | ||
| size_is_equal = ( |
There was a problem hiding this comment.
I don't see why this function used strict equality before
|
flaky failure is unrelated. |
hollymandel
pushed a commit
to hollymandel/xarray
that referenced
this pull request
Sep 23, 2024
* Make _replace more lenient. Closes pydata#5361 * review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.