Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatree setitem dataset #9516

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

TomNicholas
Copy link
Contributor

Was this the easiest feature addition ever? 😅

@TomNicholas TomNicholas added the topic-DataTree Related to the implementation of a DataTree class label Sep 18, 2024
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Pretty easy indeed :)

@TomNicholas TomNicholas merged commit a74ddf7 into pydata:main Sep 19, 2024
31 checks passed
hollymandel pushed a commit to hollymandel/xarray that referenced this pull request Sep 23, 2024
* un-xfail tests

* wrap Dataset input in a DataTree node before setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider supporting Dataset objects in DataTree.__setitem__
2 participants