Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid slashes in datatree coordinate names #9492

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Forbid slashes in datatree coordinate names #9492

wants to merge 18 commits into from

Commits on Sep 13, 2024

  1. add treenode-level tests

    @TomNicholas
    TomNicholas committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    97e8aef View commit details
    Browse the repository at this point in the history

  2. add check in child setter

    @TomNicholas
    TomNicholas committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    174c7ff View commit details
    Browse the repository at this point in the history

  3. test for non-string types

    @TomNicholas
    TomNicholas committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ec16a2d View commit details
    Browse the repository at this point in the history

  4. check for non-string types

    @TomNicholas
    TomNicholas committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    abb7ba3 View commit details
    Browse the repository at this point in the history

  5. rename check_for_slashes_in_names

    @TomNicholas
    TomNicholas committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8eeae1d View commit details
    Browse the repository at this point in the history

  6. regression test for pydata#9485

    @TomNicholas
    TomNicholas committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    83f227c View commit details
    Browse the repository at this point in the history

  7. raise instead of allow coords with slashes in names

    @TomNicholas
    TomNicholas committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d0a11c4 View commit details
    Browse the repository at this point in the history

  8. mypy

    @TomNicholas
    TomNicholas committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8eb1588 View commit details
    Browse the repository at this point in the history

  9. mypy2

    @TomNicholas
    TomNicholas committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a8bcdf9 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'main' into datatree_forbid_slashes_in_child_names

    @TomNicholas
    TomNicholas committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    684eb85 View commit details
    Browse the repository at this point in the history

  2. use _validate_name function from pydata#9494

    @TomNicholas
    TomNicholas committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e37fc64 View commit details
    Browse the repository at this point in the history

  3. remove redundant validation check

    @TomNicholas
    TomNicholas committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f1b2b31 View commit details
    Browse the repository at this point in the history

  4. add tests form pydata#9494 but at NamedNode level

    @TomNicholas
    TomNicholas committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9e2bce7 View commit details
    Browse the repository at this point in the history

  5. _validate_name -> validate_name so it can be imported from other files

    @TomNicholas
    TomNicholas committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a05bc45 View commit details
    Browse the repository at this point in the history

  6. rename name validation function

    @TomNicholas
    TomNicholas committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9bfd437 View commit details
    Browse the repository at this point in the history

  7. remove outdated import check (from when datatree was in separate repo)

    @TomNicholas
    TomNicholas committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dc9e3bd View commit details
    Browse the repository at this point in the history

  8. type hints

    @TomNicholas
    TomNicholas committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6456276 View commit details
    Browse the repository at this point in the history

  9. mypy again

    @TomNicholas
    TomNicholas committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6b894f1 View commit details
    Browse the repository at this point in the history