flox: don't set fill_value where possible #9433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes pydata#8090 Closes pydata#8206 Closes pydata#9398
dcherian
commented
Sep 5, 2024
| @@ -10387,7 +10387,7 @@ def groupby( | |||
| * letters (letters) object 16B 'a' 'b' | |||
| Dimensions without coordinates: y | |||
| Data variables: | |||
| foo (letters, y) float64 48B 9.0 11.0 13.0 9.0 11.0 13.0 | |||
| foo (letters, y) int64 48B 9 11 13 9 11 13 | |||
There was a problem hiding this comment.
This is an improvement, since dtype is preserved now
dcherian
commented
Sep 5, 2024
| @@ -787,14 +787,12 @@ def _maybe_restore_empty_groups(self, combined): | |||
| """Our index contained empty groups (e.g., from a resampling or binning). If we | |||
| reduced on that dimension, we want to restore the full index. | |||
| """ | |||
| from xarray.groupers import BinGrouper, TimeResampler | |||
|
|
|||
| has_missing_groups = ( | |||
There was a problem hiding this comment.
nice generalization.
dcherian
commented
Sep 5, 2024
| isinstance(grouper.grouper, BinGrouper | TimeResampler) | ||
| and grouper.name in combined.dims | ||
| ): | ||
| if has_missing_groups and grouper.name in combined._indexes: |
There was a problem hiding this comment.
The switch from .dims to ._indexes is a bugfix. It was caught by existing multiple grouper tests
* main: (26 commits) Forbid modifying names of DataTree objects with parents (pydata#9494) DAS-2155 - Merge datatree documentation into main docs. (pydata#9033) Make illegal path-like variable names when constructing a DataTree from a Dataset (pydata#9378) Ensure TreeNode doesn't copy in-place (pydata#9482) `open_groups` for zarr backends (pydata#9469) Update pyproject.toml (pydata#9484) New whatsnew section (pydata#9483) Release notes for v2024.09.0 (pydata#9480) Fix `DataTree.coords.__setitem__` by adding `DataTreeCoordinates` class (pydata#9451) Rename DataTree's "ds" and "data" to "dataset" (pydata#9476) Update DataTree repr to indicate inheritance (pydata#9470) Bump pypa/gh-action-pypi-publish in the actions group (pydata#9460) Repo checker (pydata#9450) Add days_in_year and decimal_year to dt accessor (pydata#9105) remove parent argument from DataTree.__init__ (pydata#9465) Fix inheritance in DataTree.copy() (pydata#9457) Implement `DataTree.__delitem__` (pydata#9453) Add ASV for datatree.from_dict (pydata#9459) Make the first argument in DataTree.from_dict positional only (pydata#9446) Fix typos across the code, doc and comments (pydata#9443) ...
* main: Opt out of floor division for float dtype time encoding (pydata#9497) fixed formatting for whats-new (pydata#9493)
|
This is a pretty internal fix and hard to review, so I'll merge in a day or so. |
hollymandel
pushed a commit
to hollymandel/xarray
that referenced
this pull request
Sep 23, 2024
* flox: don't set fill_value where possible Closes pydata#8090 Closes pydata#8206 Closes pydata#9398 * Update doctest * Fix test * fix test * Test for flox >= 0.9.12 * fix whats-new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8090
Closes #8206
Closes #9398
whats-new.rst