Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GroupBy.shuffle(), Dataset.shuffle_by(), DataArray.shuffle_by() #9320
base: main
Are you sure you want to change the base?
Add GroupBy.shuffle(), Dataset.shuffle_by(), DataArray.shuffle_by() #9320
Changes from all commits
3bc51bd
60d7619
d1429cd
31fc00e
4583853
abd9dd2
6b820aa
0d70656
fafb937
939db9a
a08450e
d0cd218
4edc976
0b42be4
c52734d
8180625
7897c91
7773548
51a7723
cc95513
18f4a40
f489bcf
ead1bb4
75115d0
390863a
a408cb0
7038f37
05a0fb4
b8e7f62
6d9ed1c
20a8cd9
7a99c8f
5e2fdfb
a22c7ed
2d48690
0679d2b
63b3e77
7dc5dd1
bad0744
91e4bd8
0542944
1e4f805
ad502aa
4b0c143
2b2c4ab
f624c8f
888e780
47e5c17
b100fb1
978fad9
d1a3fc1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, chunks will then be different sizes from each other. So when writing to Zarr we'll need to re-chunk? (asking for my clarification, feel free to not respond if it's obvious / respond with a single word :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but that's a zarr limitation :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a single group limited to a single chunk? Assuming so, if we get one giant chuck, could that present any performance problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other chunks get "auto" reshaped. This is controlled by the
chunks
kwarg, which only takes "auto" at the moment.https://docs.dask.org/en/latest/generated/dask.array.shuffle.html