Better error messages for DataTree #9222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
commented
Jul 9, 2024
TomNicholas
added
the
topic-DataTree
TomNicholas
approved these changes
Jul 9, 2024
TomNicholas
reviewed
Aug 20, 2024
TomNicholas
reviewed
Aug 20, 2024
| @@ -456,14 +456,14 @@ def _get_item(self: Tree, path: str | NodePath) -> Tree | T_DataArray: | |||
| for part in parts: | |||
| if part == "..": | |||
| if current_node.parent is None: | |||
| raise KeyError(f"Could not find node at {path}") | |||
| raise KeyError(path) | |||
There was a problem hiding this comment.
Is there a reason why you've made this error message less informative @shoyer ? The equivalent operation on a Dataset gives a more explicit message:
xr.Dataset()['a']KeyError: "No variable named 'a'. Variables on the dataset include []"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyError applies some automatic formatting, so it really only makes sense to use
raise KeyError(key).I've also tweaks a few other error messages to use more appropriate types.