-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micro optimize dataset.isel for speed on large datasets #9003
Open
hmaarrfk
wants to merge
8
commits into
pydata:main
Choose a base branch
from
hmaarrfk:micro_datasetisel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jun 22, 2024
-
Micro optimize dataset.isel for speed on large datasets
This targets optimization for datasets with many "scalar" variables (that is variables without any dimensions). This can happen in the context where you have many pieces of small metadata that relate to various facts about an experimental condition. For example, we have about 80 of these in our datasets (and I want to incrase this number) Our datasets are quite large (On the order of 1TB uncompresed) so we often have one dimension that is in the 10's of thousands. However, it has become quite slow to index in the dataset. We therefore often "carefully slice out the matadata we need" prior to doing anything with our dataset, but that isn't quite possible with you want to orchestrate things with a parent application. These optimizations are likely "minor" but considering the results of the benchmark, I think they are quite worthwhile: * main (as of pydata#9001) - 2.5k its/s * With pydata#9002 - 4.2k its/s * With this Pull Request (on top of pydata#9002) -- 6.1k its/s Thanks for considering.
Configuration menu - View commit details
-
Copy full SHA for 1f9eb68 - Browse repository at this point
Copy the full SHA 1f9eb68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53dc76e - Browse repository at this point
Copy the full SHA 53dc76eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b016dce - Browse repository at this point
Copy the full SHA b016dceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e0701a - Browse repository at this point
Copy the full SHA 4e0701aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bcf40c - Browse repository at this point
Copy the full SHA 5bcf40cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7945a3 - Browse repository at this point
Copy the full SHA f7945a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c2e5c6 - Browse repository at this point
Copy the full SHA 1c2e5c6View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fac4178 - Browse repository at this point
Copy the full SHA fac4178View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.