Skip to content

Commit

Permalink
Disable pyright config? (#9570)
Browse files Browse the repository at this point in the history
* Remove superfluous lines from pyright config

* Disable pyright config?

I'd propose disabling pyright in the `pyproject.toml` file for now, since including it means that all errors show up in devs' vscode, which then makes it more difficult to work with the actual errors. It overrides local VS Code settings, so I don't think is possible to disable...
  • Loading branch information
max-sixty authored Oct 5, 2024
1 parent 5c64182 commit 98596dd
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -214,13 +214,16 @@ warn_return_any = true

module = ["xarray.namedarray.*", "xarray.tests.test_namedarray"]

[tool.pyright]
defineConstant = {DEBUG = true}

# Enabling this means that developers who have disabled the warning locally —
# because not all dependencies are installable — are overridden
# reportMissingImports = true
reportMissingTypeStubs = false
# We disable pyright here for now, since including it means that all errors show
# up in devs' VS Code, which then makes it more difficult to work with actual
# errors. It overrides local VS Code settings so isn't escapable.

# [tool.pyright]
# defineConstant = {DEBUG = true}
# # Enabling this means that developers who have disabled the warning locally —
# # because not all dependencies are installable — are overridden
# # reportMissingImports = true
# reportMissingTypeStubs = false

[tool.ruff]
extend-exclude = [
Expand Down

0 comments on commit 98596dd

Please sign in to comment.