update compat error checking

pydata · Sep 20, 2024 · 2090862 · 2090862
1 parent 6a2eddd
commit 2090862
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/xarray/core/concat.py b/xarray/core/concat.py
@@ -255,7 +255,7 @@ def concat(
     except StopIteration:
         raise ValueError("must supply at least one object to concatenate")
 
-    if compat not in _VALID_COMPAT:
+    if compat not in set(_VALID_COMPAT) - {"minimal"}:
         raise ValueError(
             f"compat={compat!r} invalid: must be 'broadcast_equals', 'equals', 'identical', 'no_conflicts' or 'override'"
         )

diff --git a/xarray/tests/test_concat.py b/xarray/tests/test_concat.py
@@ -659,6 +659,9 @@ def test_concat_errors(self):
 
         with pytest.raises(ValueError, match=r"compat.* invalid"):
             concat(split_data, "dim1", compat="foobar")
+
+        with pytest.raises(ValueError, match=r"compat.* invalid"):
+            concat(split_data, "dim1", compat="minimal")
 
         with pytest.raises(ValueError, match=r"unexpected value for"):
             concat([data, data], "new_dim", coords="foobar")