Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix search UI description #1988

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kaycebasques
Copy link

Updates the search doc in the user guide to describe the default search UI on both narrow and wide viewports.

Also breaks all lines in the doc at 80-characters width.

Fix: #1781

Updates the search doc in the user guide to describe the default
search UI on both narrow and wide viewports.

Also breaks all lines in the doc at 80-characters width.

Fix: pydata#1781
drammock
drammock previously approved these changes Sep 19, 2024
Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

in future it would help if you separated wrapping/whitespace-only changes in a separate commit from substantive changes to the content, so we can more easily know what parts of the diff are safe to ignore.

docs/user_guide/search.rst Outdated Show resolved Hide resolved
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Co-authored-by: Daniel McCloy <[email protected]>
@kaycebasques
Copy link
Author

thanks for review @drammock, will send separate commits in the future (also easy for me to revert the whitespace fixes if you want this commit to only have the content update)

@drammock
Copy link
Collaborator

easy for me to revert the whitespace fixes if you want this commit to only have the content update

No need, I already checked it since the diff was not too large

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong info in docs page about search
2 participants