Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS - Fix link #1967

Closed
wants to merge 1 commit into from
Closed

DOCS - Fix link #1967

wants to merge 1 commit into from

Conversation

kaycebasques
Copy link

@kaycebasques kaycebasques commented Aug 29, 2024

First link to Sphinx Design on web components page is showing up in italics rather than a hyperlink.

@@ -7,9 +7,12 @@ Sphinx Design Components
On this page, you will find user interface components such as badges, buttons,
cards, and tabs.

The components on this page are **not provided by PyData Theme**.
They are provided by `Sphinx Design <https://sphinx-design.readthedocs.io/en/pydata-theme/index.html>`_ (a Sphinx extension).
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this link isn't working. The syntax looks correct.

The components on this page are **not provided by PyData Theme**. They are
provided by `Sphinx Design`_ (a Sphinx extension). This means that if you wish
to use the components on this page, you must install Sphinx Design separately
and add it to your ``conf.py``.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapped these lines at 80 characters while I was in the neighborhood

@drammock
Copy link
Collaborator

Thanks for reporting and contributing a fix!
The bad link is on our stable docs, if you check that page on our dev docs, it's already fixed (by @trallard in #1927)

@drammock drammock closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants