Bump minimum sphinx version. #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell we already implicitely requires 6.1 as this this what CI files are saying. That woudl roughly put us in line with https://scientific-python.org/specs/spec-0000/ We could likely also bump docutils to 0.19+.
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
I do not see an issue with bumping this version; like @Carreau points out, we currently test against |
trallard
approved these changes
Aug 5, 2024
trallard
added
tag: dependencies
|
Maybe not this for a 0.15.x, but for a 0.16 we should get that in. |
|
Will go ahead and merge this since there have not been any objections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell we already implicitely requires 6.1 as this this what CI files are saying.
That woudl roughly put us in line with https://scientific-python.org/specs/spec-0000/
We could likely also bump docutils to 0.19+.