BUG - Ensure coverage comment is triggered #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
kind: bug
…allard/pydata-sphinx-theme into trallard/fix-coverage-comment
Carreau
reviewed
Jun 13, 2024
|
And let's try to see if that fixes things. |
|
Woops I did not finish this because I got sidetracked with the pre-commit thing. |
Carreau
pushed a commit
that referenced
this pull request
Jun 27, 2024
I tried to fix this workflow in #1879, but the main CI workflow must first trigger the coverage comment workflow. 🎉 Right, this did it, and the comment is working as expected. I am not super thrilled with the badges' colours, as they have poor contrast (background/text colours), so I might open a PR against the action itself to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the coverage comment workflow was not being triggered due to a lack of context regarding the original workflow trigger event.
This change should ensure that it accesses the correct context only when the trigger workflow has been completed successfully.