ENH - Update copyright.html to not include the html tags. #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it is a mistake to include a tags. Note that with the exception of the `©`, the two translate blocks are almost identical, so I would also be for including the © inside the html copyright to have the same translatable strings. Closes pydata#1873
drammock
approved these changes
Jun 12, 2024
|
@trallard the "run tests & display coverage" job seems to be stalling on some (all?) PRs (e.g. here and #1862 (comment)). Do you have time to look into it? |
|
That is the coverage comment action, it seems (https://github.com/pydata/pydata-sphinx-theme/actions/workflows/coverage.yml) The coverage step in the CI workflow seems ok https://github.com/pydata/pydata-sphinx-theme/actions/runs/9483776453/job/26132093990 I can look into this in a bit |
|
This has been approved and CI is green, merging now 🚀 |
trallard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is a mistake to include a tags.
Note that with the exception of the
©, the two translate blocks are almost identical, so I would also be for including the © inside the html copyright to have the same translatable strings.Closes #1873