Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim some rendundant CSS from _header.scss #1847

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabalafou
Copy link
Collaborator

See inline comments

@@ -82,8 +82,6 @@

// Contains the navigation links within the navbar
.navbar-nav {
display: flex;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh but the _navbar-nav.scss file changes the ul to display: block... Hmm, this might be more complicated than I realize. I'm going to put this PR into draft mode.

@@ -106,10 +104,6 @@
@include header-link;
}

li a.nav-link.dropdown-item {
@include link-style-text;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line just applies the same mixin that _navbar-nav.scss appiles. The only difference is that the selector here, .bd-header .navbar-nav li a.nav-link.dropdown-item, is more specific than the other selector, .navbar-nav li a, but the specificity isn't needed to override anything, as far as I can tell.

@gabalafou gabalafou marked this pull request as draft June 3, 2024 14:25
@gabalafou gabalafou added tag: CSS CSS and SCSS related issues kind: maintenance Improving maintainability and reducing technical debt labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: maintenance Improving maintainability and reducing technical debt tag: CSS CSS and SCSS related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant