DEV - Update workflows #1831
Merged
DEV - Update workflows #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
kind: enhancement
Carreau
approved these changes
May 27, 2024
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
As I was checking pydata#1818 and the new workflows, I realized I had forgotten to update the workflow reference so that the coverage action calls the correct workflow. AFAIK the way the workflows are implemented now, the coverage comment should only trigger on PRs, so should no longer block releases, as mentioned in pydata#1818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was checking #1818 and the new workflows, I realized I had forgotten to update the workflow reference so that the coverage action calls the correct workflow.
AFAIK the way the workflows are implemented now, the coverage comment should only trigger on PRs, so should no longer block releases, as mentioned in #1818