Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env variable to control test-them build location. #1800

Merged
merged 2 commits into from
May 13, 2024

Conversation

Carreau
Copy link
Collaborator

@Carreau Carreau commented May 2, 2024

I needed this to debug some things, so why not send it as a PR.

See #1798, maybe this should be folded in #1759 ?

I needed this to debug some things, so why not send it as a PR.

See pydata#1798, maybe this should be folded in pydata#1759 ?
Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's draft mode but LGTM so far

tests/conftest.py Outdated Show resolved Hide resolved
Co-authored-by: Daniel McCloy <[email protected]>
@trallard trallard added the tag: CI Pull requests that update GitHub Actions code label May 7, 2024
@Carreau Carreau marked this pull request as ready for review May 7, 2024 12:19
@Carreau
Copy link
Collaborator Author

Carreau commented May 7, 2024

I'm going to mark as ready as I did not had any issue with this so far.

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge and incorporate into #1759

@trallard trallard added the tag: testing Issues related to PST testing label May 13, 2024
@trallard trallard merged commit 64fbfef into pydata:main May 13, 2024
21 checks passed
@Carreau
Copy link
Collaborator Author

Carreau commented May 13, 2024

Thanks !

ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
…#1800)

* Add env variable to control test-them build location.

I needed this to debug some things, so why not send it as a PR.

See pydata#1798, maybe this should be folded in pydata#1759 ?

* Update tests/conftest.py

Co-authored-by: Daniel McCloy <[email protected]>

---------

Co-authored-by: Daniel McCloy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: CI Pull requests that update GitHub Actions code tag: testing Issues related to PST testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants