fix version-switcher with dirhtml builder #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
casperdcl
force-pushed
the
fix-version-switcher-dirhtml
branch
from
c65fdb4
to
c31b7e1
Compare
9 tasks
trallard
added
kind: enhancement
|
I was having the same issue and this PR does fix it for me. Thanks @casperdcl! |
Carreau
reviewed
May 14, 2024
casperdcl
force-pushed
the
fix-version-switcher-dirhtml
branch
from
c31b7e1
to
f614def
Compare
drammock
requested changes
May 14, 2024
Coverage report
This PR does not seem to contain any modification to coverable code. |
drammock
approved these changes
May 14, 2024
casperdcl
commented
May 14, 2024
| var getCurrentUrlPath = () => { | ||
| if (DOCUMENTATION_OPTIONS.BUILDER == "dirhtml") { | ||
| return DOCUMENTATION_OPTIONS.pagename == "index" | ||
| ? `/` |
There was a problem hiding this comment.
btw I'm unsure if this would suffice (avoids duplicate // suffix, but maybe breaks in some unknown edge cases? I haven't tested it thoroughly)
Suggested change
| ? `/` | |
| ? "" |
15 tasks
|
Ok, let's try that. It seem simple enough that I believe it is safe to merge. |
9 tasks
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
Problem: version-switcher suffixes .html even if sphinx was used with the dirhtml builder. Solution: suffix / instead where necessary. --------- Co-authored-by: Daniel McCloy <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: version-switcher suffixes
.htmleven if sphinx was used with thedirhtmlbuilder.Solution: suffix
/instead where necessary.