Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GUI label contrast #1790

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

gabalafou
Copy link
Collaborator

One of many fixes for the failing accessibility tests (see #1428). The color contrast between the text and background colors in the GUI label in light mode were not meeting WCAG. This PR simply allows the label to inherit the text color of its container.

Screenshots

Before After
gui-label-light-before gui-label-light-after
gui-label-dark-before gui-label-dark-after

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this!

@choldgraf choldgraf merged commit 4087f89 into pydata:main Apr 27, 2024
19 checks passed
@gabalafou gabalafou deleted the fix-contrast-gui-label branch April 27, 2024 11:12
ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants