Replace aside tags with div tags when converting rST to HTML #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
commented
Apr 24, 2024
|
In order for this to be complete, need to also override |
gabalafou
added
the
tag: accessibility
|
In chat with Tania, we decided not to go forward with this pull request because of my concerns about maintainability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept that fixes #1479.
I'm not entirely sure this is a maintainable approach, though. The problem is that if we upgrade Sphinx, then we will need to revisit the methods that this PR overrides to make sure that they aren't missing any features that may or may not have been added in a Sphinx update.
A better approach would be a simple substitution of
asidefordivtags when the doc pages get written as HTML, but I don't know how to do that.