MAINT: various fixes to print CSS. #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
reviewed
Apr 17, 2024
|
hmm the I'll open another PR to fix that |
This should among other fix pydata#1745 When printing this hides - The pydata navbar - The announcement banner. - The "skip to main content" link. - The location breadcrumbs (in bd-header-article), without also hiding the container the full content is shifted by a dozen pixel hight and the end of the content get hidden behind the footer when printing. - The prev.next buttons a bottom of page. This does not hide the version warning banner as this is currently being worked on in another PR. I went the route of adding the bootstrat `d-print-none`, instead of adding custom css rules, I'm happy to do the opposite, but it seem the using bootstrap classes as that seems what is done in other places. I've also added a break-inside avoid in a few places, mostly to try-to avoid page breaks in the middle of codeblocks.
|
Merged |
|
Thanks ! |
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Tania Allard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should among other fix #1745
When printing this hides
- The pydata navbar
- The announcement banner.
- The "skip to main content" link.
- The location breadcrumbs (in bd-header-article), without also hiding
the container the full content is shifted by a dozen pixel hight and
the end of the content get hidden behind the footer when printing.
- The prev.next buttons a bottom of page.
This does not hide the version warning banner as this is currently being
worked on in another PR.
I went the route of adding the bootstrap
d-print-none, instead ofadding custom css rules, I'm happy to do the opposite, but it seem the
using bootstrap classes as that seems what is done in other places.
I've also added a break-inside avoid in a few places, mostly to try-to
avoid page breaks in the middle of codeblocks.