-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement @smeragoel's table designs #1757
Changes from all commits
cbe365d
cdac6b0
d7bd7bc
8fbe569
f4af604
f907229
8d8ac06
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -203,6 +203,18 @@ $pst-semantic-colors: ( | |
"light": #f3cf95, | ||
"dark": #675c04, | ||
), | ||
"table": ( | ||
"light": #{map-deep-get($color-palette, "foundation", "black")}, | ||
"dark": #{map-deep-get($color-palette, "foundation", "white")}, | ||
), | ||
"table-row-hover": ( | ||
"bg-light": #{map-deep-get($color-palette, "violet", "300")}, | ||
"bg-dark": #{map-deep-get($color-palette, "violet", "600")}, | ||
), | ||
"table-inner-border": ( | ||
"light": #{map-deep-get($color-palette, "gray", "200")}, | ||
"dark": #364150, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried using one of the theme colors, but none of them looked as good to me as the one that @smeragoel picked out, which is labeled in Figma as foreground/light/muted-old. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This works for me. IIRC, I had to slightly tweak a couple of colours as I worked on the implementation of the colour palette to meet contrast requirements here and there and this was one of the colours I ended up having to modify 👍🏽 as long as we have this as a global variable and not an ad hoc colour in a stylesheet I think this is good. |
||
), | ||
// DEPTH COLORS - you can see the elevation colours and shades | ||
// in the Figma file https://www.figma.com/file/rUrrHGhUBBIAAjQ82x6pz9/PyData-Design-system---proposal-for-implementation-(2)?node-id=1492%3A922&t=sQeQZehkOzposYEg-1 | ||
// background: color of the canvas / the furthest back layer | ||
|
@@ -265,6 +277,10 @@ $pst-semantic-colors: ( | |
& { | ||
--pst-color-link: var(--pst-color-primary); | ||
--pst-color-link-hover: var(--pst-color-secondary); | ||
--pst-color-table-outer-border: var(--pst-color-surface); | ||
--pst-color-table-heading-bg: var(--pst-color-surface); | ||
--pst-color-table-row-zebra-high-bg: var(--pst-color-on-background); | ||
--pst-color-table-row-zebra-low-bg: var(--pst-color-surface); | ||
} | ||
// adapt to light/dark-specific content | ||
@if $mode == "light" { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited this example notebook to add a pandas data table inside of an ipywidget to help us catch issues like #1740 in the future.