-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary of Axe accessibility issues #1428
Comments
cc @trallard |
Update Almost all of the Axe violations for our current set of test pages have been addressed. Our recent upgrade of Accessible-pygments fixed most of the remaining color contrast issues. There are only two remaining color contrast issues:
The only other issue has to do with ipyleaflet. When that widget fails to load, it displays a SVG icon of a broken document, but that SVG icon does not have alt text. This is also something outside our control and we will need to file an issue or pull request upstream. In the meantime, I will add code to:
Future work
|
#1787) One of many fixes for the failing accessibility tests (see #1428). The accessibility tests were still reporting some violations of: - Scrollable region must have keyboard access (https://dequeuniversity.com/rules/axe/4.8/scrollable-region-focusable) even after merging #1636 and #1777. These were due to Jupyter notebook outputs that have scrollable content. This PR extends the functionality of PRs #1636 and #1777 to such outputs. - Adds a test for tabindex = 0 on notebook outputs after page load This also addresses one of the issues in #1740: missing horizontal scrollbar by: - Adding CSS rule to allow scrolling - Add ipywidgets example to the examples/pydata page
pydata#1787) One of many fixes for the failing accessibility tests (see pydata#1428). The accessibility tests were still reporting some violations of: - Scrollable region must have keyboard access (https://dequeuniversity.com/rules/axe/4.8/scrollable-region-focusable) even after merging pydata#1636 and pydata#1777. These were due to Jupyter notebook outputs that have scrollable content. This PR extends the functionality of PRs pydata#1636 and pydata#1777 to such outputs. - Adds a test for tabindex = 0 on notebook outputs after page load This also addresses one of the issues in pydata#1740: missing horizontal scrollbar by: - Adding CSS rule to allow scrolling - Add ipywidgets example to the examples/pydata page
#1827 introduced an [Axe accessibility regression](https://dequeuniversity.com/rules/axe/4.0/scrollable-region-focusable). See also: - #1787 - #1428
If you run the accessibility checks right now:
It opens several pages and runs the Axe checker against them to find accessibility issues. There are many test failures, but only several root causes.
This issue groups the failures and links to issues to fix them. Note that some of the issues exist outside this repo (in dependencies).
Root cause: insufficiently strong color palette for the a11y-light Accessible Pygments theme
Related GitHub issue:
a11y-light fails WCAG AA contrast with gray background Quansight-Labs/accessible-pygments#30
Pages where this shows up:
Root cause: tabindex=0 not set by Sphinx on code blocks
Related GitHub issue:
ENH - Make code blocks focusable #1100
Pages where this shows up:
This is a site-wide issue so it shows up only on /user_guide/page_toc.html page in the test results.
Fixed by: Fix duplicate HTML IDs #1425
The following two site-wide issues are both fixed by the same PR:
Fixed by Remove redundant ARIA in breadcrumb navigation #1426
<li>
elements are used semantically.Fixed by Remove redundant ARIA in breadcrumb navigation #1426
There are also some color contrast issues that have to do with running Axe core (the accessibility checker) before certain animations (color transitions) finish running on the page. This results in false positive contrast failures. This is tracked in the following issue:
The following violations are site-wide and appear at /user_guide/page-toc.html, which runs Axe against the entire page. These site-wide violations are fixed by #1454:
The following site-wide violation has to do with the PyData Theme logo in the header. The alt text for the logo is
PyData Theme
, but text that immediately follows the logo icon is alsoPyData Theme
. This causes the screen reader to say it twice. This issue is fixed in #1472 and #1471:This is an issue in Sphinx Design with link cards:
The text was updated successfully, but these errors were encountered: