Skip to content

Commit

Permalink
Remove backwards-compatible text-decoration-skip rule (#1820)
Browse files Browse the repository at this point in the history
text-decoration-skip-ink was added in Safari 15.4 (March 2022)
https://developer.apple.com/documentation/safari-release-notes/safari-15_4-release-notes#CSS

We do not need to keep text-decoration-skip.
  • Loading branch information
gabalafou authored May 19, 2024
1 parent 2b276c3 commit 9761e1d
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/pydata_sphinx_theme/assets/styles/abstracts/_links.scss
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,8 @@ $link-hover-decoration-thickness: unquote("max(3px, .1875rem, .12em)") !default;
@mixin link-decoration-hover {
@if $link-hover-decoration-thickness {
text-decoration-thickness: $link-hover-decoration-thickness;
// Disable ink skipping on underlines on hover. Browsers haven't
// standardised on this part of the spec yet, so set both properties
text-decoration-skip-ink: none; // Chromium, Firefox
text-decoration-skip: none; // Safari
// Disable ink skipping on underlines on hover.
text-decoration-skip-ink: none;
}
}

Expand Down

0 comments on commit 9761e1d

Please sign in to comment.