Skip to content

Commit

Permalink
BUG - Remove schedule trigger for comment action (#1914)
Browse files Browse the repository at this point in the history
The `publish-to-pypi` workflow has failed due to the coverage comment
action since there is no PR or separate coverage branch.

This PR prevents the comment workflow from triggering in such cases and
during releases to avoid potential hiccups.

---------

Co-authored-by: Juanjo Bazán <[email protected]>
  • Loading branch information
trallard and xuanxu committed Jul 4, 2024
1 parent 4eb379d commit 0d0154b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ jobs:
- name: "Coverage comment 💬"
uses: py-cov-action/python-coverage-comment-action@v3
id: coverage_comment
# avoid running this on schedule or releases
if: github.event.workflow_run.event != 'schedule' && github.event.workflow_run.event != 'release'
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ permissions:
contents: read

jobs:
# calls our tests workflow
# calls our general CI workflow (tests, build docs, etc.)
tests:
uses: ./.github/workflows/CI.yml

Expand Down

0 comments on commit 0d0154b

Please sign in to comment.