Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix(9559)] - Validation fails for enum field with decimal type #1324

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[Fix(9559)] - Validation fails for enum field with decimal type #1324

wants to merge 15 commits into from

Commits on Jun 8, 2024

  1. Fix(9559): Validation of enum field with decimal fails

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    d736610 View commit details
    Browse the repository at this point in the history

  2. chore: Add .venv to .gitignore

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    399245b View commit details
    Browse the repository at this point in the history

  3. fix: Improve unit test case 

    The code changes modify the test cases for enum validation with decimal values. The test cases now only include the values -1, 0, and 1. Additionally, a new assertion is added to validate the decimal values as floats. This change improves the validation of enum fields with decimal values.
    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    36ce3ba View commit details
    Browse the repository at this point in the history

  4. Improve enum validation test cases for decimal values

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    dd32fc0 View commit details
    Browse the repository at this point in the history

  5. Move validate_decimal call to the last one.

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    b327afa View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. fix: make Decimal type work with StrEnum when strict mode is not enabled

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    b11d3e8 View commit details
    Browse the repository at this point in the history

  2. fix: StrEnum not supported in all envs

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    af0766c View commit details
    Browse the repository at this point in the history

  3. chore: Refactor decimal validation to the decimal module

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    6a393e4 View commit details
    Browse the repository at this point in the history

  4. refactor: simplify try_from_decimal_to_int function's return type

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    beffb8f View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. refactor: Improve enum validation test case for decimal values

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    0e23f4a View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. refactor: improve validation logic to include any type that is equal … 

    …to a validated value
    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    80308f3 View commit details
    Browse the repository at this point in the history

  2. refactor: minor refactoring for try_validate_any

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    a5e1d3d View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. refactor: make is_equal_to function generic and move it out of try_va… 

    …lidate_any

refactor: add more test coverage
    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    00b5346 View commit details
    Browse the repository at this point in the history

  2. chore: remove useless test case

    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a6c2a30 View commit details
    Browse the repository at this point in the history

  3. fix: refactoring based on code review comment 

    removed try_validate_any function and instead try to create Python enum class.

Test case modifications and fixes.
    @vai-mikkoleppanen
    vai-mikkoleppanen committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    5d6986c View commit details
    Browse the repository at this point in the history