-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experiment: build release with panic=abort
#1159
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #1159 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Let's consider rebasing this once the PyO3 changes for the "bound" API are done. There's no clear win here. |
df59ec7
to
85b38b3
Compare
I think the main win here is from better inlining of some of PyO3's internals, so maybe there's a future win to be had inside PyO3 before we try this change. |
I've updated the pr, but I think we shouldn't merge this before 2.7, given the number of changes involved, we should wait for 2.8 for this. |
I would suggest we think carefully before merging this, in particular how the changes to aborting instead of unwinding will affect users and whether that's something we actually want. |
Change Summary
Just to see what the estimated performance speedup of
panic=abort
is. It would have significantly worse UX on any panics though.Related issue number
N/A
Checklist
pydantic-core
(except for expected changes)