Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: build release with panic=abort #1159

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Just to see what the estimated performance speedup of panic=abort is. It would have significantly worse UX on any panics though.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Jan 15, 2024

CodSpeed Performance Report

Merging #1159 will not alter performance

Comparing dh/panic-abort (8ece60b) with main (031fc93)

Summary

✅ 155 untouched benchmarks

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@davidhewitt
Copy link
Contributor Author

Let's consider rebasing this once the PyO3 changes for the "bound" API are done. There's no clear win here.

@davidhewitt
Copy link
Contributor Author

I think the main win here is from better inlining of some of PyO3's internals, so maybe there's a future win to be had inside PyO3 before we try this change.

@samuelcolvin
Copy link
Member

samuelcolvin commented Mar 21, 2024

I've updated the pr, but I think we shouldn't merge this before 2.7, given the number of changes involved, we should wait for 2.8 for this.

@davidhewitt
Copy link
Contributor Author

I would suggest we think carefully before merging this, in particular how the changes to aborting instead of unwinding will affect users and whether that's something we actually want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants