Convert allow_mutation to frozen in model config #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 tasks
Kludex
requested changes
Jun 20, 2024
| @@ -38,6 +37,7 @@ | |||
| "orm_mode": "from_attributes", | |||
| "schema_extra": "json_schema_extra", | |||
| "validate_all": "validate_default", | |||
| "allow_mutation": "frozen", | |||
There was a problem hiding this comment.
Since we are going to check the same "allow_mutation" value again, there's no need to include it in this dictionary.
Comment on lines
+175
to
+180
| if node.target.value == "allow_mutation": | ||
| # The `allow_mutation` keyword is the negative of `frozen`. | ||
| if m.matches(value, m.Name(value="False")): | ||
| value = cst.Name("True") | ||
| elif m.matches(value, m.Name(value="True")): | ||
| value = cst.Name("False") |
There was a problem hiding this comment.
We can have this as an elif in the above conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mechanical transformation that is currently done for fields but not for model configs.