Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form field Enum overrides #235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rgimen3z
Copy link
Contributor

@rgimen3z rgimen3z commented Mar 4, 2024

I noticed when using an optional FormFieldSelect, the default description and placeholder would override the ones I passed to the json_schema_extra.

Fixed using a similar strategy to what we already do a few lines below in

new_schema.update({k: v for k, v in schema.items() if k != 'allOf'}) # type: ignore

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (16abe6a) to head (ac842e4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   95.68%   96.00%   +0.32%     
==========================================
  Files          14       14              
  Lines         950      951       +1     
==========================================
+ Hits          909      913       +4     
+ Misses         41       38       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant