Updates to graph class (px2ang and max_neighbors are added) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added max_neighbors argument to find_neighbors method
Turned on return_sorted to cKDTree
Added max_neighbors as an argument to get_neighbors
Made the graph symmetric when max_neighbors is used
Added px2ang as an argument for the graph class. Right now, self.coordinates_ang is used for finding the neighbors but uses self. coordinates to form the nx_graph and to plot so that the plots are made in pixel units.
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
- Coverage 74.86% 74.64% -0.22%
==========================================
Files 63 63
Lines 6474 6493 +19
==========================================
Hits 4847 4847
- Misses 1627 1646 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Added n_channels argument for the ResHedNet which now incorporates the images with multiple channels
Added n_channels (number of input channels) to all the nets in the fcnn.py file
Added n_channels argument to the method init_fcnn_model
|
@saimani5 Thank you for these updates! Can you please also add a few simple unit tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--Added px2ang argument for the graph class.
For finding the neighbors, coordinates in Angstroms are used, and for making nx_graph, coordinates in pixel units are used so that the plots make sense.
--Added max_neighbors as a kwargs argument to the find_neighbors method in the graph class.
When set to -1 (default value), the method works like the one in the previous version.
When set to any other values, the number of neighbors for each node is cut off at the 'max_neighbors.'
Additional care is also taken to avoid unidirectional edges. An edge is formed only when the nodes are connected to each other after satisfying the 'max_neighbors' argument from both sides.