-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PEP517/518 pyproject.toml
support
#203
Add PEP517/518 pyproject.toml
support
#203
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #203 +/- ##
========================================
Coverage 94.57% 94.58%
========================================
Files 44 44
Lines 1826 1829 +3
========================================
+ Hits 1727 1730 +3
Misses 99 99 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks for the contribution @agriyakhetarpal! Just one spot that's worth updating.
Some of the key changes in this PR are as follows:
ruff
andpytest
configurations are included in the newly-addedpyproject.toml
distutils
is deprecated, so I removed thesetup.py
shim file altogether considering that PyBOP in itself is a pure-Python packagepybop.version
as a private sub-module forpybop
– this ensures that no one importspybop.version.__version__
since the correct and intended way is through accessingpybop.__version__
, which is unchanged except for the fact that the version is now defined inpyproject.toml
; the good thing about this is that the package will now not have to be imported viaimport pybop
to parse the version stringP.S. I should perhaps look at doing point 4 for PyBaMM too.