Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dataframe entries #22

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Test dataframe entries #22

merged 1 commit into from
Nov 17, 2023

Conversation

julian-evers
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (30e8b0b) 76.09% compared to head (3c0a5ee) 87.43%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #22       +/-   ##
===========================================
+ Coverage   76.09%   87.43%   +11.33%     
===========================================
  Files           3        3               
  Lines         343      366       +23     
===========================================
+ Hits          261      320       +59     
+ Misses         82       46       -36     
Files Coverage Δ
pybamm_tea/tea.py 85.85% <ø> (+11.89%) ⬆️
tests/test_tea.py 96.22% <96.96%> (-0.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


# test stack energy densities dict
# import stack breakdown dataframe from csv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be cleaner to have the reference data frames just defined at the top of this file rather than reading from csv. happy to leave it as is for now though

@rtimms rtimms merged commit 20d5659 into main Nov 17, 2023
11 checks passed
@julian-evers julian-evers deleted the testing branch December 10, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants