Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: ungoofy the header at intermediate widths #393

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

sneakers-the-rat
Copy link
Contributor

i had raised this with upstream here: pydata/pydata-sphinx-theme#1784

but it's stalled because 🤷

currently at intermediate widths pydata-sphinx-theme does this whacky thing:

Screenshot 2024-08-22 at 11 26 09 PM

so this PR:

Screenshot 2024-08-22 at 11 26 36 PM

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkoyama010 tkoyama010 changed the title ungoofy the header at intermediate widths maint: ungoofy the header at intermediate widths Aug 23, 2024
@lwasser
Copy link
Member

lwasser commented Aug 23, 2024

@sneakers-the-rat are you willing to submit this to our theme instead?
we can merge this here, but ideally, we will use the theme very soon for all things guidebooks. Then we only update sphinx theme things in one place 🎉

This seems like a fix we want on the theme for our guide books. please let me know if you agree or not!! and thank you for this.

https://github.com/pyOpenSci/pyos-sphinx-theme/issues

@lwasser
Copy link
Member

lwasser commented Aug 23, 2024

so we can totally merge here but it would be better served in the theme!!

@lwasser
Copy link
Member

lwasser commented Aug 29, 2024

all looks good! let's merge 🚀 thank you Jonny!!!

@lwasser lwasser merged commit 0da208c into pyOpenSci:main Aug 29, 2024
3 of 4 checks passed
@sneakers-the-rat
Copy link
Contributor Author

oh and also i would be happy to pull it over there too, i did take a look at it bc i thought i remembered you mentioning it, but didn't see it used here yet which is why i pulled it here

@lwasser
Copy link
Member

lwasser commented Aug 30, 2024

@sneakers-the-rat thank you. that was a perfect decision!

I see your pr over there now. i left a question about how this works with sphinx. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants