Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting to enrich the annotation module #2935

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

MekJohn
Copy link

@MekJohn MekJohn commented Nov 4, 2024

  1. I'm incorporating all main parts of annotations as per ISO.
  2. Then I will try to connect those new annotation classes to PdfReader class, in order the read and get same object from and to pdf documents.
  3. Also PdfWriter will be touched in order to be sure that annotation are correctly write the new annotation object.

Added lines, dash array and border stayle base dictionary to enrich all Annotation objects. Rect updated.
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5b50f47). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pypdf/annotations/_markup_annotations.py 33.33% 23 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2935   +/-   ##
=======================================
  Coverage        ?   96.14%           
=======================================
  Files           ?       52           
  Lines           ?     8778           
  Branches        ?     1593           
=======================================
  Hits            ?     8440           
  Misses          ?      209           
  Partials        ?      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

Thanks for the PR. I suggest to not do everything at once, but in smaller PRs to simplify reviews for us as per the contribution docs. Additionally, I am going to mark this PR as draft for now. Feel free to mark it as ready for review if you think we should have a further look at it.

@stefan6419846 stefan6419846 marked this pull request as draft November 5, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants