Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab with teal #283

Closed
wants to merge 3 commits into from
Closed

Gitlab with teal #283

wants to merge 3 commits into from

Conversation

l0nax
Copy link

@l0nax l0nax commented Apr 11, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

I've removed/ moved all the content from lua/ to src/ and did not commit the new content of lua/ otherwise it would be difficult to review what has changed (in the lua code).

If merged onto master the code has to be "compiled" and put into the lua/ directory.

The code has to be "compiled" back to lua since we do not want to break the caching mechanism (slowing down the startup of Nvim):

~$ rm -rf lua/*
~$ tl build
~$ rsync -zarv --include="*/" --include="*.lua" --exclude="*" "src/" "lua/"

@l0nax l0nax force-pushed the gitlab-with-teal branch 3 times, most recently from ae02924 to 438951b Compare April 11, 2022 13:50
Revert src/octo/init back to Lua until mostly everything has been
migrated to Teal.
@farbodsz
Copy link
Contributor

farbodsz commented Nov 2, 2022

Hey @pwntester - are there any plans to merge this in the near future? Would be great to have GitLab support in Octo!

@pwntester
Copy link
Owner

Im sorry, but any GitLab support should be added in pure lua since Im not considering moving the project to Teal at this point

@pwntester pwntester closed this Nov 4, 2022
@farbodsz
Copy link
Contributor

farbodsz commented Nov 4, 2022

That's fair. @l0nax , do you think you'll work on a Lua-only version for this feature? If not, I'm happy to give it a go

@brendalf
Copy link

brendalf commented Nov 4, 2022

Hi folks, I'm almost there. I will open the MR this weekend.

@globin
Copy link

globin commented Jan 7, 2023

Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants