Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Teal with GitLab Support #282

Open
l0nax opened this issue Apr 11, 2022 · 7 comments
Open

Migration to Teal with GitLab Support #282

l0nax opened this issue Apr 11, 2022 · 7 comments

Comments

@l0nax
Copy link

l0nax commented Apr 11, 2022

Issue Description

Type: "feature request"

Describe what happened (or what feature you want)

Since I really love this plugin but mostly work with GitLab, I decided to start the migration to Teal allowing us to easily implement gitlab (or any other Host provider).

See #138

Since the code base is not small anymore, I did not migrate the whole project to Teal, instead, only the parts which are relevant for the implementation are migrated/ refactored.

Currently, only GitLab issues are implemented.

@l0nax l0nax mentioned this issue Apr 11, 2022
@pwntester
Copy link
Owner

pwntester commented Apr 11, 2022

Hi @l0nax thanks for the PR. Can you elaborate on why gitlab provider cannot be supported in plain lua? Im ok adding support for GitLab or other providers but Im not considering migrating @

@brendalf
Copy link

brendalf commented Aug 6, 2022

Hello there. I agree with @pwntester, the gitlab support should use the glab tool as backend, which is a non official gitlab cli, akin to gh cli.
In fairness, I started looking at this because I use gitlab in my company and Octo is awesome.
I'd love to work in that integration, WDYT @pwntester?
Can I open a MR with some raw work to kick off some discussions?

@pwntester
Copy link
Owner

Sure, that sounds great!

@sunzoje
Copy link

sunzoje commented Sep 6, 2022

Glab is now officially adopted by GitLab. profclems/glab#983

@brendalf
Copy link

brendalf commented Nov 4, 2022

Hi there. Sorry for taking so long. I will open the MR this weekend.

@l0nax
Copy link
Author

l0nax commented Nov 4, 2022

@sunzoje I already converted roughly about 70% of the code base to lua. I will push the changes this weekend.

@Daemoen
Copy link

Daemoen commented Jan 20, 2023

Any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants