Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add skipTeardown to env-teardown executor #61

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

BioPhoton
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Oct 23, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit adc97a1 with source commit e487162.

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 64 🟡 64 ↑ +0.2
👍 6 audits improved, 👎 1 audit regressed, 3 audits changed without impacting score

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Nx Performance Checks [Task Time] nx-verdaccio-e2e:nxv-e2e 🟨 27.34 s 🟨 26.48 s ↓ −3 %
Nx Performance Checks [Task Time] models-e2e:e2e 🟨 10.90 s 🟨 10.59 s ↓ −3 %
Nx Performance Checks [Task Time] models-e2e:nxv-env-setup 🟨 9.60 s 🟨 9.36 s ↓ −2 %
Nx Performance Checks [Task Time] models-e2e:nxv-env-bootstrap 🟩 4.11 s 🟩 3.98 s ↓ −3 %
Nx Performance Checks [Task Time] models-e2e:nxv-e2e 🟨 11.18 s 🟨 11.06 s ↓ −1 %
Nx Performance Checks [Task Time] models-e2e:nxv-env-teardown 🟩 503 ms 🟩 496 ms ↓ −1 %
Nx Performance Checks [Cache Size] nx-verdaccio-e2e:nxv-env-setup 🟨 46.64 MB 🟨 46.64 MB ↑ +0 %
Nx Performance Checks [Task Time] cli-e2e-original:original-e2e 🟥 172.60 s 🟥 168.14 s ↓ −3 %
Nx Performance Checks [Graph Time] task graph 🟥 3210.52 ms 🟥 3094.69 ms ↓ −4 %
Nx Performance Checks [Graph Time] project graph 🟥 2840.78 ms 🟥 2835.94 ms ↓ +0 %

1 other audit is unchanged.

@BioPhoton BioPhoton merged commit 664c6bd into main Oct 23, 2024
7 checks passed
@BioPhoton BioPhoton deleted the add-skip-teardown branch October 23, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant