-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement glob, cp, opendir and other methods #86
base: master
Are you sure you want to change the base?
Conversation
…test --censor-stats --strict --pedantic-packages
I think done |
@@ -34,7 +37,7 @@ foreign import copyFile_FICLONE :: CopyMode | |||
-- | If present, the copy operation will attempt to create a copy-on-write reflink. If the underlying platform does not support copy-on-write, then the operation will fail with an error. | |||
foreign import copyFile_FICLONE_FORCE :: CopyMode | |||
|
|||
defaultCopyMode = copyFile_EXCL :: CopyMode | |||
defaultCopyMode = copyFile_NO_FLAGS :: CopyMode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a good default, overwriting should be opt-in since it's more dangerous.
defaultCopyMode = copyFile_NO_FLAGS :: CopyMode | |
defaultCopyMode = copyFile_EXCL :: CopyMode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it is the default option by nodejs documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…" property must be of type function. Received null
…must be of type function. Received null
Description of the change
implement #82 (comment)
but not watchfiles
used this to play in js
Checklist: