Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Stdlib::Host to no longer accept subnets #1432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change Stdlib::Host to no longer accept subnets #1432

wants to merge 1 commit into from
+3 −1

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Jun 27, 2024

A host should be a specific IP and not allow a subnet.

@ekohl
Change Stdlib::Host to no longer accept subnets
48c51e6 
A host should be a specific IP and not allow a subnet.
bastelfreak
bastelfreak approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, we should keep the PR open until the next major release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner

@b4ldr b4ldr Awaiting requested review from b4ldr b4ldr is a code owner

@smortex smortex Awaiting requested review from smortex smortex is a code owner

@seanmil seanmil Awaiting requested review from seanmil seanmil is a code owner

Assignees
No one assigned
Labels
backwards-incompatible community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekohl @kenyon @bastelfreak @ia-content