Fixes to profile images for fog/Google Cloud Storage #9958

jywarren · 2021-07-27T18:57:38Z

Follow-up to #9807 to try fixing profile images

See: https://publiclab.org/profile/liz to test, or https://stable.publiclab.org/profile/liz

gitpod-io · 2021-07-27T18:57:41Z

codeclimate · 2021-07-27T18:58:47Z

app/models/user.rb

-  has_attached_file :photo, styles: { thumb: '200x200#', medium: '500x500#', large: '800x800#' },
-                                    url: '/system/profile/photos/:id/:style/:basename.:extension'
+  has_attached_file :photo, styles: { thumb: '200x200#', medium: '500x500#', large: '800x800#' }
+	#,


Incorrect indentation detected (column 1 instead of 8).

codeclimate · 2021-07-27T18:58:47Z

app/models/user.rb

-                                    url: '/system/profile/photos/:id/:style/:basename.:extension'
+  has_attached_file :photo, styles: { thumb: '200x200#', medium: '500x500#', large: '800x800#' }
+	#,
+        #                            url: '/system/profile/photos/:id/:style/:basename.:extension'


Incorrect indentation detected (column 8 instead of 2).

codeclimate · 2021-07-27T18:58:47Z

app/models/user.rb

-  has_attached_file :photo, styles: { thumb: '200x200#', medium: '500x500#', large: '800x800#' },
-                                    url: '/system/profile/photos/:id/:style/:basename.:extension'
+  has_attached_file :photo, styles: { thumb: '200x200#', medium: '500x500#', large: '800x800#' }
+	#,


Missing space after #.

codeclimate · 2021-07-27T18:58:47Z

app/models/user.rb

  #:path => ":rails_root/public/system/images/photos/:id/:style/:basename.:extension"
+  #.        ":rails_root/public/system/public/system/:class/:attachment/:id_partition/:style/:filename" # from config/initializers/paperclip.rb


Missing space after #.

codeclimate · 2021-07-27T18:58:47Z

app/models/user.rb

-  has_attached_file :photo, styles: { thumb: '200x200#', medium: '500x500#', large: '800x800#' },
-                                    url: '/system/profile/photos/:id/:style/:basename.:extension'
+  has_attached_file :photo, styles: { thumb: '200x200#', medium: '500x500#', large: '800x800#' }
+	#,


Tab detected.

jywarren · 2021-07-27T20:41:37Z

Pushed this to unstable to test...

codeclimate · 2021-08-03T18:31:48Z

app/models/user.rb

-  has_attached_file :photo, styles: { thumb: '200x200#', medium: '500x500#', large: '800x800#' },
-                                    url: '/system/profile/photos/:id/:style/:basename.:extension'
+  has_attached_file :photo,
+                    styles: { thumb: '200x200#', medium: '500x500#', large: '800x800#' },


Use one level of indentation for parameters following the first line of a multi-line method call.

codecov · 2021-08-03T18:42:41Z

Codecov Report

Merging #9958 (37170c8) into main (f41f8e7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 37170c8 differs from pull request most recent head 4388759. Consider uploading reports for the commit 4388759 to get more accurate results

@@            Coverage Diff             @@
##             main    #9958      +/-   ##
==========================================
+ Coverage   82.13%   82.18%   +0.04%     
==========================================
  Files          98       98              
  Lines        5968     5967       -1     
==========================================
+ Hits         4902     4904       +2     
+ Misses       1066     1063       -3

Impacted Files	Coverage Δ
app/controllers/images_controller.rb	`70.27% <100.00%> (ø)`
app/helpers/application_helper.rb	`87.62% <100.00%> (+2.21%)`	⬆️
app/models/user.rb	`86.12% <100.00%> (ø)`
app/services/search_service.rb	`95.00% <100.00%> (-0.10%)`	⬇️
app/controllers/user_tags_controller.rb	`83.78% <0.00%> (+1.35%)`	⬆️

jywarren · 2021-08-03T19:14:23Z

OK, so now we are forming the path to the image correctly -- /public/system/users/photos/000/000/001/thumb/aseprite_templates.png however all profiles point to the same image, for some reason!

jywarren · 2021-08-03T20:02:43Z

OK, trying :id_partition instead of :id in the url: setting...

jywarren · 2021-08-03T20:39:15Z

OK - new images seem to be OK. But the problem is that old images followed a different scheme and are stored in locations like this:

https://storage.googleapis.com/publiclab-production/public/system/profile/photos/554/thumb/Bristol-539-7.jpg

(ref https://web.archive.org/web/20200318121317im_/https://publiclab.org/system/profile/photos/554/thumb/Bristol-539-7.jpg)

https://console.cloud.google.com/storage/browser/_details/publiclab-production/public/system/profile/photos/554/original/Bristol-539-7.jpg?project=public-lab

jywarren · 2021-08-03T20:42:23Z

We can check: https://unstable.publiclab.org/notes/firas/03-13-2017/exhibition-and-mapping-workshops-in-bourj-al-shamali

jywarren · 2021-08-03T20:46:18Z

Tested this in GitPod and it should work. Testing on unstable now.

codeclimate · 2021-08-03T20:47:04Z

Code Climate has analyzed commit 4388759 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Style	1

View more on Code Climate.

jywarren · 2021-08-03T21:15:06Z

OK! I believe this is working and ready to deploy!!

jywarren · 2021-08-03T21:15:29Z

system test error should disappear:

Minitest::UnexpectedError:         Capybara::ExpectationNotMet: expected to find css "div.alert-success" but there were no matches
            test/system/post_test.rb:253:in `block in <class:PostTest>'

icarito · 2021-08-18T04:55:11Z

I'm finding missing images in a different directory. So I think we might have a routing issue. E.g.

https://storage.googleapis.com/publiclab- production/public/system/profile/photos/7/original/384404446-square.png
but it's being searched at /public/system/users/photos/000/000/007/thumb/384404446-square.png

jywarren · 2021-08-23T17:41:21Z

Ah so in these URLs, it's users but it should be profiles?

jywarren · 2021-08-23T17:42:25Z

app/models/user.rb

+  has_attached_file :photo,
+                    styles: { thumb: '200x200#', medium: '500x500#', large: '800x800#' },
+                    url: '/public/system/profile/photos/:id/:style/:basename.:extension',
+                    path: ':rails_root/public/system/public/system/profile/photos/:id/:style/:filename'


Oh wait, the other way around. So the images you're finding are at users but we are pointing to profile?

I had been working from this old image: https://storage.googleapis.com/publiclab-production/public/system/profile/photos/554/thumb/Bristol-539-7.jpg which currently works.

jywarren · 2021-08-23T18:10:32Z

Confirmed it worked!

so, images are now pointed at https://unstable.publiclab.org/public/system/profile/photos/152/thumb/DSCN6508.JPG

so i remove "unstable." and it works https://publiclab.org/public/system/profile/photos/152/thumb/DSCN6508.JPG

i'll try uploading a new image just to final check

great, i believe it worked!

it uploaded to https://publiclab.org/public/system/profile/photos/1/medium/aseprite_templates.png

ok, let's merge and deploy

jywarren · 2021-08-23T21:20:43Z

It worked!!! https://publiclab.org/notes/firas/03-13-2017/exhibition-and-mapping-workshops-in-bourj-al-shamali

* Update user.rb * adjusted url param for profile images * adjusted custom route for profile images

github-actions bot added the work-in-progress label Jul 27, 2021

jywarren changed the title ~~Update user.rb~~ Fixes to profile images Jul 27, 2021

jywarren changed the title ~~Fixes to profile images~~ Fixes to profile images for fog/Google Cloud Storage Jul 27, 2021

codeclimate bot reviewed Jul 27, 2021

View reviewed changes

jywarren mentioned this pull request Jul 27, 2021

Profile images on profile page aren't lazy loading #9957

Closed

github-actions bot added ready-for-review and removed work-in-progress labels Jul 27, 2021

jywarren mentioned this pull request Jul 29, 2021

Prune Comment System Tests for Faster CI #9752

Merged

jywarren added 2 commits August 3, 2021 18:03

Update user.rb

35d61af

adjusted url param for profile images

7c35136

jywarren force-pushed the profile-images-fog branch from 344c16b to 7c35136 Compare August 3, 2021 18:30

github-actions bot added the work-in-progress label Aug 3, 2021

codeclimate bot reviewed Aug 3, 2021

View reviewed changes

github-actions bot removed the work-in-progress label Aug 3, 2021

adjusted custom route for profile images

4388759

github-actions bot added the work-in-progress label Aug 3, 2021

github-actions bot removed the work-in-progress label Aug 3, 2021

jywarren commented Aug 23, 2021

View reviewed changes

jywarren merged commit d3a19b3 into main Aug 23, 2021

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021

Fixes to profile images for fog/Google Cloud Storage (publiclab#9958)

51ebb61

* Update user.rb * adjusted url param for profile images * adjusted custom route for profile images

billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021

Fixes to profile images for fog/Google Cloud Storage (publiclab#9958)

a342303

* Update user.rb * adjusted url param for profile images * adjusted custom route for profile images

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes to profile images for fog/Google Cloud Storage #9958

Fixes to profile images for fog/Google Cloud Storage #9958

jywarren commented Jul 27, 2021 •

edited

Loading

gitpod-io bot commented Jul 27, 2021

codeclimate bot Jul 27, 2021

codeclimate bot Jul 27, 2021

codeclimate bot Jul 27, 2021

codeclimate bot Jul 27, 2021

codeclimate bot Jul 27, 2021

jywarren commented Jul 27, 2021

codeclimate bot Aug 3, 2021

codecov bot commented Aug 3, 2021 •

edited

Loading

jywarren commented Aug 3, 2021

jywarren commented Aug 3, 2021

jywarren commented Aug 3, 2021

jywarren commented Aug 3, 2021

jywarren commented Aug 3, 2021

codeclimate bot commented Aug 3, 2021

jywarren commented Aug 3, 2021

jywarren commented Aug 3, 2021

icarito commented Aug 18, 2021 •

edited by jywarren

Loading

jywarren commented Aug 23, 2021

jywarren Aug 23, 2021

jywarren Aug 23, 2021

jywarren commented Aug 23, 2021

jywarren commented Aug 23, 2021

		#:path => ":rails_root/public/system/images/photos/:id/:style/:basename.:extension"
		#. ":rails_root/public/system/public/system/:class/:attachment/:id_partition/:style/:filename" # from config/initializers/paperclip.rb

Fixes to profile images for fog/Google Cloud Storage #9958

Fixes to profile images for fog/Google Cloud Storage #9958

Conversation

jywarren commented Jul 27, 2021 • edited Loading

gitpod-io bot commented Jul 27, 2021

codeclimate bot Jul 27, 2021

Choose a reason for hiding this comment

codeclimate bot Jul 27, 2021

Choose a reason for hiding this comment

codeclimate bot Jul 27, 2021

Choose a reason for hiding this comment

codeclimate bot Jul 27, 2021

Choose a reason for hiding this comment

codeclimate bot Jul 27, 2021

Choose a reason for hiding this comment

jywarren commented Jul 27, 2021

codeclimate bot Aug 3, 2021

Choose a reason for hiding this comment

codecov bot commented Aug 3, 2021 • edited Loading

Codecov Report

jywarren commented Aug 3, 2021

jywarren commented Aug 3, 2021

jywarren commented Aug 3, 2021

jywarren commented Aug 3, 2021

jywarren commented Aug 3, 2021

codeclimate bot commented Aug 3, 2021

jywarren commented Aug 3, 2021

jywarren commented Aug 3, 2021

icarito commented Aug 18, 2021 • edited by jywarren Loading

jywarren commented Aug 23, 2021

jywarren Aug 23, 2021

Choose a reason for hiding this comment

jywarren Aug 23, 2021

Choose a reason for hiding this comment

jywarren commented Aug 23, 2021

jywarren commented Aug 23, 2021

jywarren commented Jul 27, 2021 •

edited

Loading

codecov bot commented Aug 3, 2021 •

edited

Loading

icarito commented Aug 18, 2021 •

edited by jywarren

Loading